Setup use of has_concretization and test with SciMLOperators/WOperator #847
+159
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
force-pushed
the
claude/open-linearsol-pr-019f2nZ8STSAH5PaVG3PVNep
branch
2 times, most recently
from
f7663de to
a293e0a
Compare
…ctorizations - Add `has_concretization` import from SciMLOperators to enable checking operator concretization support - Add `init_cacheval` methods for `AbstractSciMLOperator` types with sparse factorization algorithms: - KLUFactorization - UMFPACKFactorization - LUFactorization - CHOLMODFactorization - GenericFactorization - GenericLUFactorization - QRFactorization - NormalCholeskyFactorization - When an operator has `has_concretization`, it is converted to an AbstractMatrix and the appropriate sparse solver is used - Add tests for MatrixOperator and WOperator with sparse matrices - Bump SciMLOperators lower bound to v1.13 (WOperator was added in v1.13.0)
ChrisRackauckas
force-pushed
the
claude/open-linearsol-pr-019f2nZ8STSAH5PaVG3PVNep
branch
from
a293e0a to
b8cfa09
Compare
Replace plain error() calls with a custom exception type when operators that don't support concretization are passed to factorization algorithms.
Import has_concretization directly from SciMLOperators instead of LinearSolve, since LinearSolve doesn't re-export it.
The init_cacheval methods need to return nothing when concretization is not supported, so that the default algorithm selection can fall back to other methods like Krylov solvers.
ChrisRackauckas
deleted the
claude/open-linearsol-pr-019f2nZ8STSAH5PaVG3PVNep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.