Skip to content

Remove LUFactorization method for AbstractSciMLOperator #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Dec 11, 2025
Merged

Remove LUFactorization method for AbstractSciMLOperator #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ext/LinearSolveSparseArraysExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,18 +300,6 @@ function LinearSolve.init_cacheval(
end
end

function LinearSolve.init_cacheval(
alg::LUFactorization, A::AbstractSciMLOperator, b, u, Pl, Pr,
maxiters::Int, abstol, reltol,
verbose::Union{LinearVerbosity, Bool}, assumptions::OperatorAssumptions)
if has_concretization(A)
return LinearSolve.init_cacheval(alg, convert(AbstractMatrix, A), b, u, Pl, Pr,
maxiters, abstol, reltol, verbose, assumptions)
else
nothing
end
end

function LinearSolve.init_cacheval(
alg::CHOLMODFactorization, A::AbstractSciMLOperator, b, u, Pl, Pr,
maxiters::Int, abstol, reltol,
Expand Down
10 changes: 0 additions & 10 deletions test/basictests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,11 +584,6 @@ end
sol_operator = solve(prob_operator, UMFPACKFactorization())
@test sol_matrix.u ≈ sol_operator.u

# Test LU with operator
sol_matrix = solve(prob_matrix, LUFactorization())
sol_operator = solve(prob_operator, LUFactorization())
@test sol_matrix.u ≈ sol_operator.u

# Test WOperator with sparse Jacobian
n_w = 8
M = sparse(I(n_w) * 1.0)
Expand All @@ -612,11 +607,6 @@ end
sol_woperator = solve(prob_woperator, UMFPACKFactorization())
sol_wmatrix = solve(prob_wmatrix, UMFPACKFactorization())
@test sol_woperator.u ≈ sol_wmatrix.u

# Test LU with WOperator
sol_woperator = solve(prob_woperator, LUFactorization())
sol_wmatrix = solve(prob_wmatrix, LUFactorization())
@test sol_woperator.u ≈ sol_wmatrix.u
end

@testset "Solve Function" begin
Expand Down
Loading