[ Awaiting Review ] Implement WENO Scheme #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 88.56% 89.41% +0.84%
==========================================
Files 23 25 +2
Lines 1067 1228 +161
==========================================
+ Hits 945 1098 +153
- Misses 122 130 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Member
Author
|
@ChrisRackauckas Can you review? Corners are still 0, I will extrapolate them in a seperate PR |
xtalax
changed the title
| """ | ||
| `generate_extrap_eqs` | ||
| Pads the boundaries with extrapolation equations, extrapolated with 6th order lagrangian polynomials. |
Member
Author
There was a problem hiding this comment.
To maintain 5th order accuracy for weno, it is used in the spec.
Comment on lines
-94
to
+147
| @testset "Test 01: Burger's Equation 2D" begin | ||
| @parameters x y t | ||
| @variables u(..) v(..) | ||
| Dt = Differential(t) | ||
| Dx = Differential(x) | ||
| Dy = Differential(y) | ||
| Dxx = Differential(x)^2 | ||
| Dyy = Differential(y)^2 | ||
| # @testset "Test 01: Burger's Equation 2D" begin |
Member
Author
There was a problem hiding this comment.
This has never passed, I'm not sure its even correct.
ChrisRackauckas
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #102
fixes #136
fixes #143
fixes #141
TODO:
Any comments on possible Interface designs or boundary handling welcome.
Stretch: