Skip to content

Conversation

@xtalax
Copy link
Member

@xtalax xtalax commented Feb 24, 2022

More interface tests coming

  • Shallow Water
  • Burger's

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #39 (3c59e80) into master (7fba480) will decrease coverage by 8.70%.
The diff coverage is 87.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   93.18%   84.47%   -8.71%     
==========================================
  Files          11       11              
  Lines         660      728      +68     
==========================================
  Hits          615      615              
- Misses         45      113      +68     
Impacted Files Coverage Δ
src/discretization/discretize_vars.jl 88.13% <75.00%> (-1.52%) ⬇️
src/MOL_utils.jl 89.28% <84.21%> (-5.26%) ⬇️
src/bcs/boundary_types.jl 98.83% <100.00%> (ø)
src/discretization/MOL_discretization.jl 100.00% <100.00%> (ø)
...discretization/generate_finite_difference_rules.jl 95.18% <100.00%> (ø)
src/discretization/fornberg.jl 0.00% <0.00%> (-100.00%) ⬇️
src/interiormap.jl 79.61% <0.00%> (-11.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fba480...3c59e80. Read the comment docs.

@xtalax
Copy link
Member Author

xtalax commented Mar 1, 2022

Fixes #11, #33, #1, #3 is already fixed as well as #9 and #4, all failing (now passing) examples have been added to the interface test.

@ChrisRackauckas ChrisRackauckas merged commit 5de0a08 into SciML:master Mar 1, 2022
@ChrisRackauckas
Copy link
Member

Amazing!

@xtalax
Copy link
Member Author

xtalax commented Mar 1, 2022

wait I forgot to push a commit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants