#33

[xtalax]

fixes #33, #4, #1, #9 and #3
(Some of these were fixed by the previous pr)

[ChrisRackauckas]

I'm glad this was a separate PR anyways. We should keep distinct ideas in separate PRs to make it easier to read.

[codecov]

Codecov Report

Merging #44 (e4a6e95) into master (3c59e80) will increase coverage by 8.42%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   84.47%   92.90%   +8.42%     
==========================================
  Files          11       11              
  Lines         728      761      +33     
==========================================
+ Hits          615      707      +92     
+ Misses        113       54      -59     

Impacted Files	Coverage Δ
src/interiormap.jl	91.26% <ø> (+11.65%)	⬆️
src/discretization/discretize_vars.jl	89.06% <88.88%> (+0.92%)	⬆️
src/MOLFiniteDifference.jl	85.71% <100.00%> (+5.71%)	⬆️
src/bcs/boundary_types.jl	98.85% <100.00%> (+0.01%)	⬆️
src/bcs/generate_bc_eqs.jl	79.77% <100.00%> (+4.13%)	⬆️
src/discretization/MOL_discretization.jl	100.00% <100.00%> (ø)
...discretization/generate_finite_difference_rules.jl	95.18% <100.00%> (ø)
src/discretization/fornberg.jl	100.00% <0.00%> (+100.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c59e80...e4a6e95. Read the comment docs.

[xtalax]

@ChrisRackauckas please remember to also close #1, #3, #9 and #4

[ChrisRackauckas]

If you do "fixes #1, #3, #9 and #4" in the first post then it would do it automatically.

[xtalax]

Worth knowing.