Update interiormap construction to use ranking #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 90.08% 88.07% -2.02%
==========================================
Files 12 13 +1
Lines 918 939 +21
==========================================
Hits 827 827
- Misses 91 112 +21
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
|
||
|
|
||
| @testset "Test 06: Dt(u(t,x)) ~ Dxx(u(t,x)), time-dependent Robin BCs, Order 6" begin | ||
| @test_broken begin #@testset "Test 06: Dt(u(t,x)) ~ Dxx(u(t,x)), time-dependent Robin BCs, Order 6" begin |
Member
There was a problem hiding this comment.
this breaks a test but doesn't fix one?
Member
Author
There was a problem hiding this comment.
That was the test that was already broken, check the CI for the last merge. We didn't have a test for this case, I can add an MWE for what this fixes?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a ranking rather than boolean based heuristic for matching equations with variables.
Fixes #78
Fixes #75