-
-
Notifications
You must be signed in to change notification settings - Fork 46
Hydraulic library updated to use macros #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7dd7cba
Hydraulic library updated to use macros
matthew-kapp 59432e6
Hydraulic library updated to use macros
matthew-kapp 418c060
Hydraulic library updated to use macros
matthew-kapp 82c6951
gitignore reverted
matthew-kapp 5394538
Merge branch 'main' into hydraulic-macros
matthew-kapp 6fad3a0
reversible=false added to DynamicVolume in docstring
matthew-kapp 96371e9
Merge branch 'SciML:main' into hydraulic-macros
matthew-kapp 644d620
Implemented reviewer comments
matthew-kapp 21b80b6
Merge remote-tracking branch 'origin' into hydraulic-macros
matthew-kapp c064fda
Merge branch 'hydraulic-macros' of https://github.com/matthew-kapp/Mo…
matthew-kapp 7b0fbf9
FixedVolume modified to remove free variables
matthew-kapp 4494224
VolumeBase.structural_parameters: (x1,x2) changed to (X1,X2) - case s…
matthew-kapp 21c6340
VolumeBase.structural_parameters: X changed to symbolic(X)
matthew-kapp d5c56dc
Merge branch 'main' into hydraulic-macros
matthew-kapp b65ded4
Symbolics pinned to v6.29.2 in Project.toml
matthew-kapp e25b17c
tests failing fixed
matthew-kapp 1fe68dd
Merge branch 'main' into hydraulic-macros
matthew-kapp f4088b5
Project.toml reverted
matthew-kapp 49a0262
Merge branch 'SciML:main' into hydraulic-macros
matthew-kapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaults = [rho => liquid_density(port)]can be added via the
@defaultsblock https://docs.sciml.ai/ModelingToolkit/stable/basics/MTKLanguage/#@defaults-begin-blockThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?