Add missing isadaptive import from SciMLBase in NonlinearSolveBase #750
+16
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas-Claude
force-pushed
the
fix-isadaptive-import
branch
4 times, most recently
from
c781525 to
2d41ee3
Compare
Changes to NonlinearSolveBase: - Removed `isadapt` parameter from all `get_concrete_problem` signatures - Hardcoded `true` in `get_concrete_u0` calls - Updated all callers to not pass the `true` argument The `isadapt` parameter is only meaningful for ODE solvers with adaptive timestepping. For nonlinear problems, this concept doesn't apply. Changes to NonlinearSolveHomotopyContinuation: - Simplified Aqua tests since persistent_tasks now passes on Julia 1.11+ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
fix-isadaptive-import
branch
from
2d41ee3 to
858c7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isadaptiveto the imports fromSciMLBaseinNonlinearSolveBase.jlisadaptivefunction is used insolve.jlat lines 647 and 669 but was never importedProblem
When solving a
SteadyStateProblemwith adjoint sensitivity analysis (e.g., usingQuadratureAdjoint()), the following error occurs:This happens because
isadaptive(alg)is called in_solve_forwardand_solve_adjointfunctions to check if the algorithm uses adaptive timestepping, but the function was never imported fromSciMLBase.Test plan
🤖 Generated with Claude Code