Ambiguity errors and format #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what it's for either, and don't remember seeing it used anywhere. A quick browse through the parts of SciMLBase I know also doesn't use it. Hopefully we should be good? Tests seem to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AayushSabharwal I'm trying to see if adding
::NTuple{N, Int}is a valid signature onDiffEqArray.Having
::NTuple{N}in the third position is compatible withNTuple{N,Symbol}, resulting in ambiguities with the following two constructors.This is an attempt to avoid that ambiguity, while being totally ignorant of what that third argument in the first constructor is actually supposed to be.