Skip to content

Remove unnecessary val-type in copyat_or_push! #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Remove unnecessary val-type in copyat_or_push! #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ copyat_or_push!{T}(a::AbstractVector{T},i::Int,x)

If `i<length(x)`, it's simply a `recursivecopy!` to the `i`th element. Otherwise, it will
`push!` a `deepcopy`.
"""
function copyat_or_push!(a::AbstractVector{T},i::Int,x,nc::Type{Val{perform_copy}}=Val{true}) where {T,perform_copy}
"""
function copyat_or_push!(a::AbstractVector{T},i::Int,x,perform_copy=true) where {T}
@inbounds if length(a) >= i
if !ArrayInterfaceCore.ismutable(T) || !perform_copy
# TODO: Check for `setindex!`` if T <: StaticArraysCore.StaticArray and use `copy!(b[i],a[i])`
Expand All @@ -171,7 +171,11 @@ function copyat_or_push!(a::AbstractVector{T},i::Int,x,nc::Type{Val{perform_copy
end
nothing
end


function copyat_or_push!(a::AbstractVector{T},i::Int,x,nc::Type{Val{perform_copy}}) where {T, perform_copy}
copyat_or_push!(a,i,x,perform_copy)
end

"""
```julia
recursive_one(a)
Expand Down