-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add JET tests #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JET tests #506
Conversation
|
So the remaining errors from JET.jl are all because of |
|
You can set it to ignore that function |
There is not option for filtering specific functions directly in JET.jl, right? So now I first get all reports, then manually filter out the |
I thought there was? At least the Aqua use of JET has it? |
.github/workflows/JET.yml
Outdated
| @@ -0,0 +1,60 @@ | |||
| name: JET | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of a new workflow it should just be a new test group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't be possible because we cannot add JET.jl to the Project.toml and test on julia pre-v1.12 and v1.12 due to package compat connstraints, see NumericalMathematics/DispersiveShallowWater.jl#216 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it just needs to allow JET v0.9 and v0.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean something like 2acf709? Let's see if that works. Last time I tried to make something like this work, I always got compat problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, seems fine.
Can you point me to that please? |
|
Oh actually that's just for implicit import checks. So this approach seems fine. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
As discussed in #501 (comment), this adds JET.jl tests. I'll try to also fix any potential issues reported by JET.jl here.