Bump downstream OrdinaryDiffEq/MTK compat for RAT 4.x#593
Merged
ChrisRackauckas merged 1 commit intoMay 17, 2026
Merged
Conversation
RecursiveArrayTools 4.x is incompatible with all OrdinaryDiffEq 6.x versions reachable under the current dep graph: Adapt 4 narrows OrdinaryDiffEq to 6.64.0 - 6.111.0, and OrdinaryDiffEq 6.110+ pins RecursiveArrayTools to 3.52.0 - 3, leaving an empty intersection. The only working path is OrdinaryDiffEq 7, which in turn requires MTK 10+, so bump both compat entries. This unblocks `activate_downstream_env` (which fails at Pkg.develop on master). Downstream test sources have separate, follow-on issues that the resolver previously masked (OrdinaryDiffEq 7 `autodiff::Bool` deprecation, `Rodas5`/`SciMLBase` no longer reexported from OrdinaryDiffEq, MTK 11 `getindex` behavior in symbol_indexing.jl, missing `using RecursiveArrayToolsShorthandConstructors` for `AP[...]`). Those are out of scope here. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores
Tests - Downstreamto green. Master has been red on Downstream Julia 1/lts/pre for weeks; this PR makes the resolver succeed and updates the downstream sources for the OrdinaryDiffEq 7 API the bump exposes.Compat changes (
test/downstream/Project.toml)OrdinaryDiffEq = "6.31"→"6.31, 7"ModelingToolkit = "8.33, 9"→"8.33, 9, 10, 11"(OrdinaryDiffEq 7 transitively wants MTK 10+)OrdinaryDiffEqRosenbrock = "1, 2"(no longer re-exported from OrdinaryDiffEq)RecursiveArrayToolsShorthandConstructors(used by theAP[...]shorthand introduced in 334bd95)Why the resolver was unsatisfiable on master
Adapt = "4"(required by RAT 4.x) narrows OrdinaryDiffEq to[4.0.0 - 5.39.1, 6.64.0 - 7.0.0].RecursiveArrayTools = "3.52.0 - 3".Downstream source fixes (exposed once the resolver succeeds)
Rosenbrock23(autodiff = false)→Rosenbrock23(autodiff = AutoFiniteDiff()). OrdinaryDiffEq 7 rejectsBooland asks for an ADType.using OrdinaryDiffEqRosenbrocktoodesolve.jl(providesRodas5).using RecursiveArrayToolsShorthandConstructorstoodesolve.jlanddownstream_events.jl(needed forAP[...]).SciMLBase.successful_retcode(sol)→ unqualifiedsuccessful_retcode(sol).SciMLBaseis not a bare binding viausing OrdinaryDiffEq, butsuccessful_retcodeandAutoFiniteDiffare — so we avoid addingSciMLBase/ADTypesas direct deps, which would unresolvably conflict with RAT 4.3's transitive SciMLBase 3 requirement.After (this branch)
Out of scope
test/downstream/symbol_indexing.jl(run in theSymbolicIndexingInterfacegroup) still has many failures, almost certainly from MTK 11 / SymbolicIndexingInterface API changes around symbolic-array indexing. Worth its own investigation — not gating this PR.test/downstream/adjoints.jlremains commented out inruntests.jlper the pre-existing# TODO: re-enable after SciMLBase compat bump for RAT v4note.Test plan
Pkg.activate+Pkg.develop+Pkg.instantiatefortest/downstream)ODE Solve Testssafetestset passes locally (4 pass, 1 pre-existing broken)Event Tests with ArrayPartitionsafetestset runs without errorMeasurements and Unitssafetestset passes (1 pre-existing broken)TrackerExtsafetestset passes (1 pass)