Support CartesianIndices for VectorOfArray

[YingboMa]

No description provided.

[andreasnoack]

The testing here is insufficient. The abstract array contract is violated

julia> IndexStyle(v)
IndexCartesian()

julia> v[CartesianIndex(size(v))]
ERROR: BoundsError: attempt to access 3-element Array{Array{Float64,N} where N,1} at index [20]
Stacktrace:
 [1] getindex at ./array.jl:788 [inlined]
 [2] getindex(::VectorOfArray{Float64,2,Array{Array{Float64,N} where N,1}}, ::CartesianIndex{2}) at /Users/andreasnoack/.julia/packages/RecursiveArrayTools/Wx7AV/src/vector_of_array.jl:46
 [3] top-level scope at REPL[124]:1

Hasn't this change broken a lot of DiffEq tests?

julia> x = [rand(2) for i in 1:3]
3-element Array{Array{Float64,1},1}:
 [0.9852201256045343, 0.32847272010896966]
 [0.9368428797761215, 0.9223074651115168]
 [0.2577978464729409, 0.9482205432256972]

julia> xde = RecursiveArrayTools.DiffEqArray(x, [1.0, 2.0, 3.0])
t: 3-element Array{Float64,1}:
 1.0
 2.0
 3.0
u: 3-element Array{Array{Float64,1},1}:
 [0.9852201256045343, 0.32847272010896966]
 [0.9368428797761215, 0.9223074651115168]
 [0.2577978464729409, 0.9482205432256972]

julia> hcat(x...)
2×3 Array{Float64,2}:
 0.98522   0.936843  0.257798
 0.328473  0.922307  0.948221

julia> hcat(x...) - xde
2×3 Array{Float64,2}:
  0.0      0.60837  0.257798
 -0.60837  0.0      0.948221

and it gives bounds errors if bounds checking is enabled.

Also, the show method lies about the type

julia> v = VectorOfArray([zeros(20), zeros(10,10), zeros(3,3,3)])
3-element Array{Array{Float64,N} where N,1}:
...

[ChrisRackauckas]

It broke a ton of downstream tests. It'll get worked on today.