Add global lock around the caching mechanism #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #8
I had some confusing deadlocks trying out
ReentrantLock, so I opted to useSpinLockhere. Generally that's not advisable, but I think the inside of the locked regions here should be minimal enough that it's safe.As to the cause of the deadlock, I don't really know what that's about. Perhaps it's causing us to accidentally task switch when running the
@generatedfunction body... I could imagine that interacting badly with the compiler somehow.