ci: use build matrix #508
Merged
ci: use build matrix #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thazhemadam
force-pushed
the
at/ci-build-matrix
branch
2 times, most recently
from
ead9852 to
86e22fb
Compare
Buildkite doesn't support specifying `adjustments` for
`timeout_in_minutes` [1].
We can't specify the default value of `240` for a variable, say
`timeout`, in the matrix, add an `adjustment` step for `timeout`'s value
and interpolate it into `timeout_in_minutes`
(as `timeout_in_minutes: {{matrix.timeout}}) either, since trying to
interpolate matrix values into "top-level" throws a splice error [2].
So, explicitly run the job(s) that need to be run with a timeout of
`360` mins as a completely different step instead.
[1] https://buildkite.com/julialang/stochasticdiffeq-dot-jl/builds/444#0183e442-c5fc-4d94-a3a3-70e9636f735c/53-58
[2] https://buildkite.com/julialang/stochasticdiffeq-dot-jl/builds/447#0183e451-e4f6-4d47-bb3c-e2086d73405a/54-59
thazhemadam
force-pushed
the
at/ci-build-matrix
branch
2 times, most recently
from
a5bccd3 to
2bcac52
Compare
There's no need to have a `matrix.setup` defined since we need (and use) only the values in `matrix.group`; which we can access using `matrix` alone. So, remove the `matrix.version` and replace `matrix.setup` with `matrix`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use buildkite's build matrix instead of having duplicated CI steps.