Skip to content

Conversation

@AayushSabharwal
Copy link
Member

  • All interface functions have sensible defaults
  • All interface functions by default compare Symbol
  • Update documentation
  • Add SymbolCache docstring

Ref. SciML/ModelingToolkit.jl#1997

- All interface functions have sensible defaults
- All interface functions by default compare `Symbol`
- Update documentation
- Add `SymbolCache` docstring
@AayushSabharwal AayushSabharwal changed the title Add default methods interface functions Add default methods for interface functions Dec 13, 2022
@AayushSabharwal
Copy link
Member Author

Docs don't want to build 🤔

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6 (21344da) into master (900ef7e) will increase coverage by 45.45%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
+ Coverage    0.00%   45.45%   +45.45%     
===========================================
  Files           1        2        +1     
  Lines          19       22        +3     
===========================================
+ Hits            0       10       +10     
+ Misses         19       12        -7     
Impacted Files Coverage Δ
src/symbolcache.jl 41.66% <ø> (+41.66%) ⬆️
src/interface.jl 50.00% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AayushSabharwal
Copy link
Member Author

This should help make sure changes here work with the RecursiveArrayTools at least

@ChrisRackauckas ChrisRackauckas merged commit 59f7970 into master Dec 13, 2022
@ChrisRackauckas ChrisRackauckas deleted the symbol-cast branch December 13, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants