Implements to display ytick #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I implementd it so that ytick is displayed. But I could not control the direction in which ytick was displayed. For details, attach an image to PR.
Member
|
This is great! What's also great is that you could easily change the code so I think the architecture is pretty good as of now 😄 However, there is one small problem. The Y ticks in your example are showing as vertical lines. Could you please change the |
Member
|
@284km can you please send the corrections to the master branch? |
Contributor
Author
|
OK, I will send again to master branch after fix. |
Merged
Contributor
Author
|
I fixed and sent new PR #33 to master. so close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implement it so that ytick is displayed.
ytick is now displayed. But I couldn't control the direction in which ytick was displayed as in the image below.
I thought about a concrete collaboration plan with charty, but I could not draw any conclusions yet.
I have read the rubyplot code, so I tried implementing.