Merged
Conversation
Contributor
Review Summary by QodoAdd HTTP client timeout to Membase plugin
WalkthroughsDescription• Add 5-second timeout to Membase HTTP client • Improve HTTP request reliability with timeout configuration Diagramflowchart LR
A["MembasePlugin RegisterDI"] -- "ConfigureHttpClient" --> B["HTTP Client Configuration"]
B -- "Set BaseAddress" --> C["Membase API Connection"]
B -- "Set Timeout 5s" --> C
File Changes1. src/Plugins/BotSharp.Plugin.Membase/MembasePlugin.cs
|
Contributor
Code Review by Qodo
1. Unvalidated settings.Host URI
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| .ConfigureHttpClient(c => c.BaseAddress = new Uri(settings.Host)); | ||
| .ConfigureHttpClient(c => | ||
| { | ||
| c.BaseAddress = new Uri(settings.Host); |
Contributor
There was a problem hiding this comment.
1. Unvalidated settings.host uri 📘 Rule violation ⛯ Reliability
The new code constructs and assigns BaseAddress directly from settings.Host without null/empty/format validation, which can throw during startup if config is missing or not an absolute URI. This violates the requirement to add null/empty guards and safe fallbacks at external/config boundaries.
Agent Prompt
## Issue description
`settings.Host` is used at a configuration boundary without null/empty/format checks (`new Uri(settings.Host)`), which can throw at runtime (e.g., missing scheme, empty string).
## Issue Context
`MembaseSettings` is populated via `config.Bind("Membase", settings)`, so `Host` is externally provided and should be validated before using it as `HttpClient.BaseAddress`.
## Fix Focus Areas
- src/Plugins/BotSharp.Plugin.Membase/MembasePlugin.cs[30-34]
- src/Plugins/BotSharp.Plugin.Membase/Settings/MembaseSettings.cs[3-8]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| .ConfigureHttpClient(c => | ||
| { | ||
| c.BaseAddress = new Uri(settings.Host); | ||
| c.Timeout = TimeSpan.FromSeconds(5); |
Contributor
There was a problem hiding this comment.
2. Timeout masked as success 🐞 Bug ✓ Correctness
When IMembaseApi calls fail (including from the new 5s timeout), MembaseGraphDb catches the
exception and returns an empty GraphQueryResult, and MembaseController then returns HTTP 200 with
empty Columns/Items. This turns timeouts into silent, incorrect "successful" responses for
/membase/{graphId}/query.
Agent Prompt
### Issue description
Failures from Membase API calls (including HttpClient timeouts introduced in this PR) are swallowed in `MembaseGraphDb.ExecuteQueryAsync` and returned as `new GraphQueryResult()`. `MembaseController` then always returns `200 OK` with empty `Columns/Items`, masking timeouts as successful responses.
### Issue Context
This becomes significantly more impactful after the PR because a 5-second HttpClient timeout will trigger cancellations in normal operation.
### Fix Focus Areas
- src/Plugins/BotSharp.Plugin.Membase/GraphDb/MembaseGraphDb.cs[39-60]
- src/Plugins/BotSharp.Plugin.Membase/Controllers/MembaseController.cs[40-60]
- src/Plugins/BotSharp.Plugin.Membase/MembasePlugin.cs[30-34]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.