Fix NDArray.mgrid and add unit tests. Also corrects the Object compar… #314
Conversation
|
Resolves #313 |
test/NumSharp.UnitTest/README.md
Outdated
|
|
||
| `PS D:\Projects\NumSharp> OpenCover.Console -register:user -target:"dotnet.exe" -targetargs:test -filter:"+[NumSharp.UnitTest]*" -output:"coverage.xml" -oldstyle` | ||
| `PS D:\Projects\NumSharp> codecov -f coverage.xml -t <codecov-numsharp-token>` | ||
| `PS D:\Projects\NumSharp> codecov -f coverage.xml -t <codecov-numsharp-token>` |
There was a problem hiding this comment.
Please revert the changes in this file,
See comments below
test/NumSharp.UnitTest/README.md
Outdated
| is some Python code that spits out C# definitions for static NDArrays | ||
| that can be used in unit tests: | ||
|
|
||
| ```python |
There was a problem hiding this comment.
The generating code should be placed in NumSharp.UnitTest/Utilities/ndarray-generator.py (or named anything of that sort)
test/NumSharp.UnitTest/README.md
Outdated
| print("") | ||
|
|
||
| # generate mgrid unit test data (we're trusting Python here) | ||
| aa, bb = np.mgrid[0:5, 0:3] |
There was a problem hiding this comment.
The code that was used to generate you can place as a comment in Creation/NdArray.Mgrid.Test.cs
…er for NDArray to compare shape and data contents.
|
Updated and squashed with all requested changes. |
|
Thanks, @Nucs ! Is there a chance of getting the NuGet pushed up right away? My project is using Azure IoT Edge devices which get built in docker containers, so there's no good way to get this update (which is on my critical path) without nuget. |
|
@Oceania2018, can you release a minor update (0.10.4) for NumSharp? There are quite few changes by the last release. |
|
Sure, Before releasing, I have to fix another issue. I need to sign the library. |
|
@JetstreamRoySprowl |
|
@Nucs , @Oceania2018 , just what I needed -- thanks so much! |
3 participants
Fix NDArray.mgrid and add unit tests. Also corrects the Object comparer for NDArray to compare shape and data contents.