-
Notifications
You must be signed in to change notification settings - Fork 297
Reinstate grib as_messages. #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Given this, I think we again have a consistent form of grib support. Remaining PR not included :
|
5ca74d3 to
55ebdf7
Compare
There are also a couple of older ones still in the pot, but I think no urgency on these ? ...
|
NB. Irrespective of whether we go the iris-grib route we want this change. |
I don't understand why you've not reinstated this - by default I'd rather it was back again. |
|
With the exception of the |
Ok, you're right. |
|
Super, thanks. 👍 Any chance of a squash? |
7eaef82 to
e2127d0
Compare
|
sqwished ! |
|
Excellent - that gets grib handling back into the state where it doesn't need a major version change. 👍 |
This function was removed by #1941, when it should just have been deprecated.
The test
iris.tests.unit.fileformats.gribtest "test_as_messages" is not reinstated, as "test_as_pairs" covers it.As a complete aside, I also spotted the ECMWF link in the module header was broken + fixed that.