Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented May 11, 2016

This function was removed by #1941, when it should just have been deprecated.
The test iris.tests.unit.fileformats.grib test "test_as_messages" is not reinstated, as "test_as_pairs" covers it.
As a complete aside, I also spotted the ECMWF link in the module header was broken + fixed that.

@pp-mo
Copy link
Member Author

pp-mo commented May 11, 2016

Given this, I think we again have a consistent form of grib support.
This can serve as a sensible basis for subbing out grib support to "iris_grib" as proposed here

Remaining PR not included :
#1755 "grib1 future" is not in included in this.
It seeks to provides Grib1 support through the new "strict" loader , but we aren't finished agreeing it.
It should be pretty easy to carry those changes over into the new iris-grib package when required.
The point is, hopefully, that by pushing those problems into iris-grib, we don't need to provide alternatives to grib1 loading before cutting Iris 1.10.
Instead we propose:

  • iris 1.10 deprecates iris.fileformats.grib in favour of iris-grib
  • iris 2.0 removes iris.fileformats.grib
  • grib-api 1.0 retains both 'old' + 'new' grib loaders
  • non-strict support can be removed at grib-api 2.0

@pp-mo pp-mo force-pushed the grib_reinstate_as_messages branch from 5ca74d3 to 55ebdf7 Compare May 11, 2016 12:29
@rhattersley rhattersley added this to the v1.10 milestone May 11, 2016
@pp-mo
Copy link
Member Author

pp-mo commented May 11, 2016

Remaining PR not included :

There are also a couple of older ones still in the pot, but I think no urgency on these ? ...

@rhattersley
Copy link
Member

This can serve as a sensible basis for subbing out grib support to "iris_grib" as proposed here

NB. Irrespective of whether we go the iris-grib route we want this change.

@rhattersley
Copy link
Member

The test iris.tests.unit.fileformats.grib test "test_as_messages" is not reinstated

I don't understand why you've not reinstated this - by default I'd rather it was back again.

@rhattersley
Copy link
Member

With the exception of the test_as_messages question I'm 👍

@pp-mo
Copy link
Member Author

pp-mo commented May 11, 2016

I don't understand why you've not reinstated this

Ok, you're right.

@rhattersley
Copy link
Member

Super, thanks. 👍 Any chance of a squash?

@pp-mo pp-mo force-pushed the grib_reinstate_as_messages branch from 7eaef82 to e2127d0 Compare May 12, 2016 11:32
@pp-mo
Copy link
Member Author

pp-mo commented May 12, 2016

sqwished !

@rhattersley rhattersley merged commit 34c0889 into SciTools:master May 12, 2016
@rhattersley
Copy link
Member

Excellent - that gets grib handling back into the state where it doesn't need a major version change. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants