Skip to content

Conversation

@trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Please merge via merge-commit (not squash)


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

pp-mo and others added 6 commits April 30, 2025 16:02
* Add lychee-based linkcheck workflow.

* Remove old nox-based per-PR linkcheck.

* Remove nox-linkcheck from python-version-checks test.

* Configure manifest to exclude the linkcheck ignores file.

* Update .github/workflows/ci-linkchecks.yml

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Update .github/workflows/ci-linkchecks.yml

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Add links badge to README.

* Test urls in all files python, exclude or replace failing urls in python.

* Run checks every day, including weekends.

* Apply Iris-friendly labels to linkcheck failure Issues.

---------

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
* Update Iris benchmarking to align with templating.

* Revert licence header changes - align with test expectations.
* Remove setup.py develop command.

* Protect from setuptools>=80 incompatibility.

* Relocate What's New entry.
* Whats new updates for v3.12.1 .

* Correct typo.
@trexfeathers trexfeathers added the Type: Merge Back Merging a feature branch back to main label May 1, 2025
@trexfeathers trexfeathers requested a review from ESadek-MO May 1, 2025 11:56
@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (c0b5ac5) to head (dc33b2e).
⚠️ Report is 98 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6435   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files          90       90           
  Lines       23752    23752           
  Branches     4418     4418           
=======================================
  Hits        21331    21331           
  Misses       1672     1672           
  Partials      749      749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ESadek-MO
Copy link
Contributor

Should the duplicate whatsnew entry (in latest on main) be removed as part of this pull? Or are we happy to just do that seperately?

@trexfeathers
Copy link
Contributor Author

Should the duplicate whatsnew entry (in latest on main) be removed as part of this pull? Or are we happy to just do that seperately?

Yes you're right. I think perhaps I should have originally targetted v3.12.x, to avoid this sort of confusion.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ESadek-MO ESadek-MO merged commit 416b23e into SciTools:main May 2, 2025
21 checks passed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton May 31, 2025
@trexfeathers trexfeathers deleted the 3121-mergeback branch August 22, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Merge Back Merging a feature branch back to main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants