Rationalise CML #6713
Merged
Rationalise CML #6713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of `assert_CML_approx_data`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6713 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 91 91
Lines 24476 24476
Branches 4571 4571
=======================================
Hits 22101 22101
Misses 1607 1607
Partials 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* upstream/main: collapsed preserving masked aux coords (SciTools#6719) aggregated_by preserving masked aux coords (SciTools#6706) [pre-commit.ci] pre-commit autoupdate (SciTools#6720) Fix UCAR linkcheck failures. (SciTools#6718) Bump pypa/gh-action-pypi-publish from 1.12.4 to 1.13.0 (SciTools#6709) Bump scitools/workflows from 2025.09.3 to 2025.09.4 (SciTools#6708)
bjlittle
requested changes
Sep 25, 2025
There was a problem hiding this comment.
@ukmo-ccbunney Nice piece of rationalization! 💯
Some super minors to consider, otherwise LGTM 👌
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
bjlittle
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Removes the
assert_CML_approx_datafunction.The functionality is now provided in
assert_CMLwith a newapprox_datakeyword.Addresses the first bullet point of #6244