Skip to content

Adapt benchmarks asv_delegated.py for wntrblm/nox#1072#7046

Merged
pp-mo merged 1 commit intoSciTools:mainfrom
trexfeathers:bm-nox-20260410
Apr 13, 2026
Merged

Adapt benchmarks asv_delegated.py for wntrblm/nox#1072#7046
pp-mo merged 1 commit intoSciTools:mainfrom
trexfeathers:bm-nox-20260410

Conversation

@trexfeathers
Copy link
Copy Markdown
Contributor

The current script is breaking because it was written on the assumption that Nox would only place the environment directory in the specified parent. It now also places a .gitignore and a CACHEDIR.TAG file too, presumably to help with Nox's internals.

scitools-ci[bot]
scitools-ci Bot previously requested changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@scitools-ci scitools-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templating

This PR includes changes that may be worth sharing via templating. For each file listed below, please either:

  • Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github templates/ directory. 1
  • Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
  • Dismiss the suggestion if the changes are not suitable for templating.

You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.

Templated files

The following changed files are templated:

Footnotes

  1. Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
    @scitools-templating: please no update notification on: iris

@trexfeathers trexfeathers dismissed scitools-ci[bot]’s stale review April 13, 2026 16:32

I checked - we don't include this in the benchmark template. Makes sense given asv_delegated.py is specifically designed with the intention of being customised for each repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (287706c) to head (371b355).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7046   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files          91       91           
  Lines       24951    24951           
  Branches     4683     4683           
=======================================
  Hits        22488    22488           
  Misses       1684     1684           
  Partials      779      779           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pp-mo pp-mo merged commit cbeaf22 into SciTools:main Apr 13, 2026
26 checks passed
@pp-mo
Copy link
Copy Markdown
Member

pp-mo commented Apr 13, 2026

@trexfeathers we don't include this in the benchmark template

TBH though, there is a lot in common between iris + iris-esmf-regrid versions of 'asv_delegated.py`.
Why isn't templating a good way of addressing that ?

@trexfeathers
Copy link
Copy Markdown
Contributor Author

@trexfeathers we don't include this in the benchmark template

TBH though, there is a lot in common between iris + iris-esmf-regrid versions of 'asv_delegated.py`. Why isn't templating a good way of addressing that ?

The template isn't there to just facilitate alignment between Iris and IER, it's also there to facilitate the addition of benchmarking to other repositories. I've made that as easy as I possibly can, but so far no-one has taken an interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants