Adapt benchmarks asv_delegated.py for wntrblm/nox#1072#7046
Adapt benchmarks asv_delegated.py for wntrblm/nox#1072#7046pp-mo merged 1 commit intoSciTools:mainfrom
asv_delegated.py for wntrblm/nox#1072#7046Conversation
There was a problem hiding this comment.
Templating
This PR includes changes that may be worth sharing via templating. For each file listed below, please either:
- Action the suggestion via a pull request editing/adding the relevant file in the SciTools/.github
templates/directory. 1 - Raise an issue against the SciTools/.github repo for the above action if you really don't have 10mins spare right now. Include an assignee, to avoid it being forgotten.
- Dismiss the suggestion if the changes are not suitable for templating.
You will need to dismiss this review before this PR can be merged. Recommend the reviewer does this as their final action before merging, as this text will continually update as commits come in.
Templated files
The following changed files are templated:
Footnotes
-
Include this text in the PR body to avoid any notifications about applying the template changes back to the source repo!
@scitools-templating: please no update notification on: iris↩
I checked - we don't include this in the benchmark template. Makes sense given asv_delegated.py is specifically designed with the intention of being customised for each repository.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
=======================================
Coverage 90.12% 90.12%
=======================================
Files 91 91
Lines 24951 24951
Branches 4683 4683
=======================================
Hits 22488 22488
Misses 1684 1684
Partials 779 779 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TBH though, there is a lot in common between iris + iris-esmf-regrid versions of 'asv_delegated.py`. |
The template isn't there to just facilitate alignment between Iris and IER, it's also there to facilitate the addition of benchmarking to other repositories. I've made that as easy as I possibly can, but so far no-one has taken an interest. |
The current script is breaking because it was written on the assumption that Nox would only place the environment directory in the specified parent. It now also places a
.gitignoreand aCACHEDIR.TAGfile too, presumably to help with Nox's internals.