subloader: Add version 1.7.0#17680
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new Scoop manifest Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/verify |
coderabbitai
Bot
added
the
package-request-needed
|
All changes look good. Wait for review from human collaborators. subloader
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
bucket/subloader.json (1)
20-20: Verify the pre-uninstall script exists and consider simplifying the syntax.The manifest references
clean_registry.regwhich should be included in the release artifact. Additionally, the current syntax can be simplified.Verify the file exists (this check is covered by the post_install verification script above).
♻️ Consider simplifying the pre-uninstall syntax
Most Scoop manifests use a simpler syntax for importing registry files:
- "pre_uninstall": "powershell -NoProfile -Command \"reg.exe import '$dir\\clean_registry.reg'\"", + "pre_uninstall": "if ($cmd -eq 'uninstall') { reg import \"$dir\\clean_registry.reg\" }",This follows the pattern used in other Extras manifests and adds a safety check to only run during actual uninstallation (not upgrades).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/subloader.json` at line 20, The manifest's pre_uninstall entry references clean_registry.reg but doesn't confirm the file is packaged and uses verbose syntax; ensure clean_registry.reg is included in the release artifact (so post_install verification can find it) and replace the current verbose pre_uninstall command with the simpler, common pattern used by other manifests that both imports "$dir\\clean_registry.reg" and guards execution so it only runs on real uninstalls (not upgrades). Update the pre_uninstall value (symbol: pre_uninstall) to the simplified guarded PowerShell invocation and verify the post_install verification script still validates presence of clean_registry.reg.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/subloader.json`:
- Around line 1-5: Create a package-request issue for the new Subloader package
and add its issue number to the PR description; specifically, open the template
at the provided URL to file a "package-request" for "Subloader" (the package
named in bucket/subloader.json and the "description" field), then edit the PR
body to include the produced issue number (e.g., `#12345`) so the new-package
submission follows the repository guideline requiring a linked package request
issue.
- Line 5: The manifest's license field currently uses a non‑SPDX identifier;
update the "license" JSON key in subloader.json from "MIT-Modern-Variant" to the
standard SPDX identifier "MIT" so it matches the repository LICENSE content and
valid SPDX usage.
- Around line 1-11: The manifest is missing a "suggest" field declaring the .NET
10 runtime; add a top-level "suggest" object (alongside "version",
"description", "architecture", etc.) that maps a human-readable key like ".NET
10 Runtime" to the Scoop package identifier used for .NET 10 (e.g.
"dotnet/runtime" or the exact identifier used in the main bucket), so add that
mapping under the "suggest" key and verify/adjust the package id to match the
Scoop main bucket naming convention.
---
Nitpick comments:
In `@bucket/subloader.json`:
- Line 20: The manifest's pre_uninstall entry references clean_registry.reg but
doesn't confirm the file is packaged and uses verbose syntax; ensure
clean_registry.reg is included in the release artifact (so post_install
verification can find it) and replace the current verbose pre_uninstall command
with the simpler, common pattern used by other manifests that both imports
"$dir\\clean_registry.reg" and guards execution so it only runs on real
uninstalls (not upgrades). Update the pre_uninstall value (symbol:
pre_uninstall) to the simplified guarded PowerShell invocation and verify the
post_install verification script still validates presence of clean_registry.reg.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3c29c17b-52b5-4779-a288-3231e3eaba0c
📒 Files selected for processing (1)
bucket/subloader.json
coderabbitai
Bot
removed
the
package-request-needed
Apply runtime suggestion Co-authored-by: z-Fng <54583083+z-Fng@users.noreply.github.com>
3 participants
Subloader v1.7.0
Closes #17681
Hi, would like to contribute to Scoop package manager and add my app for downloading subtitles.
Project page: Subloader GitHub
I have been maintaining this app since 2018. It has more than 100 stars and regular users, here are the stats:
Upper graph shows number of subtitles downloaded per day and lower graph the number of users that login to Opensubtitles API using the app every day, although anonymous usage is also possible.
The app has both GUI and CLI version. CLI version enables you to search and batch download subtitles for entire directories. All functionalities you can find described on the project page and wiki.
Post-install script adds associations to mkv, mp4 and avi files and adds a "Find subtitles" context menu to those files.
Pre-uninstall script removed these associations. Configs are stored in %appdata%.
I have actually maintained a scoop app manifest in my repository for quite some time and was using it but would like to add it to a scoop bucket because I use scoop regularly, and it will be more accesible.
Install Test
Uninstall Test
Checkver Test
<manifest-name[@version]|chore>: <general summary of the pull request>