nsq: Add version 1.3.0#6549
Open
sdfwds4 wants to merge 1 commit intoScoopInstaller:masterfrom
Open
Conversation
A realtime distributed messaging platform. https://github.com/nsqio/nsq
Contributor
|
Your changes do not pass checks. nsq
|
aliesbelik
suggested changes
Feb 19, 2025
Contributor
aliesbelik
left a comment
aliesbelik
left a comment
There was a problem hiding this comment.
Extract Go version along with app's version since it differs from release to release as well.
| "version": "1.3.0", | ||
| "description": "A realtime distributed messaging platform", | ||
| "homepage": "https://nsq.io", | ||
| "license": "MIT license", |
Contributor
There was a problem hiding this comment.
Suggested change
| "license": "MIT license", | |
| "license": "MIT", |
Comment on lines
+24
to
+32
| "checkver": { | ||
| "github": "https://github.com/nsqio/nsq/" | ||
| }, | ||
| "autoupdate": { | ||
| "url": "https://github.com/nsqio/nsq/releases/download/v$version/nsq-$version.windows-amd64.go1.21.5.tar.gz", | ||
| "hash": { | ||
| "url": "$url.sha256" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| "checkver": { | |
| "github": "https://github.com/nsqio/nsq/" | |
| }, | |
| "autoupdate": { | |
| "url": "https://github.com/nsqio/nsq/releases/download/v$version/nsq-$version.windows-amd64.go1.21.5.tar.gz", | |
| "hash": { | |
| "url": "$url.sha256" | |
| } | |
| } | |
| "checkver": { | |
| "url": "https://api.github.com/repositories/4307108/releases/latest", | |
| "jsonpath": "$..browser_download_url", | |
| "regex": "nsq-([\\d.]+).windows-amd64.go(?<go>[\\d.]+)\\.tar\\.gz" | |
| }, | |
| "autoupdate": { | |
| "architecture": { | |
| "64bit": { | |
| "url": "https://github.com/nsqio/nsq/releases/download/v$version/nsq-$version.windows-amd64.go$matchGo.tar.gz", | |
| "extract_dir": "nsq-$version.windows-amd64.go$matchGo" | |
| } | |
| } | |
| } |
Lutra-Fs
requested changes
May 26, 2025
Member
Lutra-Fs
left a comment
Lutra-Fs
left a comment
There was a problem hiding this comment.
Hi there,
I agree with aliesbelik’s review comment. I think it would be best if you could either:
a) explain why you don’t want to apply this suggestion, or
b) go ahead and apply it.
Just marking the review as resolved without any explanation or changes isn’t ideal, as it can leave others confused. Clear communication really helps everyone stay on the same page!
Thanks for your understanding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A realtime distributed messaging platform. https://github.com/nsqio/nsq