greenshot-unstable: Update to version 1.3.299, fix checkver & autoupdate#2463
Conversation
WalkthroughUpdated the Scoop manifest for Greenshot unstable to version 1.3.299, switching to the UNSIGNED installer variant. Adjusted the download URL, SHA256 hash, checkver regex, and autoupdate URL to match the new naming convention. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Maintainer
participant Scoop as Scoop checkver
participant GH as GitHub Releases
participant Manifest as greenshot-unstable.json
Dev->>Scoop: Run checkver -update
Scoop->>Manifest: Read regex and autoupdate template
Scoop->>GH: Fetch latest release metadata
GH-->>Scoop: Release assets list
Scoop->>Scoop: Match regex "…-UNSTABLE-UNSIGNED"
Scoop->>Manifest: Populate autoupdate URL with -UNSIGNED
Scoop->>GH: Download installer to compute hash
GH-->>Scoop: .exe bytes
Scoop->>Manifest: Write updated version, url, hash
note over Scoop,Manifest: Flow updated to expect "-UNSTABLE-UNSIGNED" asset
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. greenshot-unstable
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/greenshot-unstable.json (1)
20-20: Tighten regex to avoid accidental matches (anchor .exe).
Safer to match the installer asset explicitly; prevents matching a similarly named non-installer artifact in the future.Apply:
- "regex": "Greenshot-INSTALLER-([\\d.]+)-UNSTABLE-UNSIGNED" + "regex": "Greenshot-INSTALLER-([\\d.]+)-UNSTABLE-UNSIGNED\\.exe"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/greenshot-unstable.json(2 hunks)
🔇 Additional comments (3)
bucket/greenshot-unstable.json (3)
2-2: Version bump to 1.3.299 aligns with UNSIGNED asset naming — looks good.
23-23: Autoupdate URL updated to UNSIGNED variant — good.
This will follow the new naming going forward.
6-7: URL and hash verified — UNSIGNED installer asset is live and checksum matches.
Downloaded successfully (HTTP 200, 4,207,170 bytes); SHA256 = 2a03634d14f0de9ae319c06bc4800ee89011374018bb042f15a378e4e82d4951 (matches JSON).
|
Thanks! By the way, please make sure to follow the Contributing Guide next time.
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. greenshot-unstable
|
Greenshot unstable added
UNSIGNEDto the end of the exe name for unstable releases. This PR updates the URLs for the new naming scheme.Closes #2461
Summary by CodeRabbit
New Features
Bug Fixes
Chores