Skip to content

greenshot-unstable: Update to version 1.3.299, fix checkver & autoupdate#2463

Merged
z-Fng merged 1 commit intoScoopInstaller:masterfrom
BradKnowles:bugfix/greenshot-unstable-naming
Sep 21, 2025
Merged

greenshot-unstable: Update to version 1.3.299, fix checkver & autoupdate#2463
z-Fng merged 1 commit intoScoopInstaller:masterfrom
BradKnowles:bugfix/greenshot-unstable-naming

Conversation

@BradKnowles
Copy link
Copy Markdown
Contributor

@BradKnowles BradKnowles commented Sep 13, 2025

Greenshot unstable added UNSIGNED to the end of the exe name for unstable releases. This PR updates the URLs for the new naming scheme.

Closes #2461

Summary by CodeRabbit

  • New Features

    • None.
  • Bug Fixes

    • None.
  • Chores

    • Updated Greenshot (unstable) to version 1.3.299.
    • Switched installer source to the UNSIGNED unstable build to match upstream availability.
    • Refreshed download URL and checksum for the new build.
    • Adjusted release detection and auto-update to track the UNSIGNED variant.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Sep 13, 2025

Walkthrough

Updated the Scoop manifest for Greenshot unstable to version 1.3.299, switching to the UNSIGNED installer variant. Adjusted the download URL, SHA256 hash, checkver regex, and autoupdate URL to match the new naming convention.

Changes

Cohort / File(s) Summary
Greenshot unstable manifest
bucket/greenshot-unstable.json
Bumped version 1.3.292 → 1.3.299; updated url to UNSIGNED installer; refreshed hash; changed checkver.regex to match -UNSTABLE-UNSIGNED; updated autoupdate.url to UNSIGNED path.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Maintainer
    participant Scoop as Scoop checkver
    participant GH as GitHub Releases
    participant Manifest as greenshot-unstable.json

    Dev->>Scoop: Run checkver -update
    Scoop->>Manifest: Read regex and autoupdate template
    Scoop->>GH: Fetch latest release metadata
    GH-->>Scoop: Release assets list
    Scoop->>Scoop: Match regex "…-UNSTABLE-UNSIGNED"
    Scoop->>Manifest: Populate autoupdate URL with -UNSIGNED
    Scoop->>GH: Download installer to compute hash
    GH-->>Scoop: .exe bytes
    Scoop->>Manifest: Write updated version, url, hash

    note over Scoop,Manifest: Flow updated to expect "-UNSTABLE-UNSIGNED" asset
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through buckets, swift and keen,
Nudged the regex—now it’s clean.
UNSIGNED moons on version’s crest,
1.3.299 hops to the test.
URLs aligned, the hash in tow—
A tidy trail where updates flow. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues Check ✅ Passed The changes implement the linked issue [#2461]: the manifest's url, checkver.regex, and autoupdate.url were updated to include "-UNSIGNED" and the version and hash were bumped to the unsigned installer, which addresses the 404/autoupdate failure described in the issue. The updated regex and autoupdate URL are consistent with the new asset naming and the new hash corresponds to the updated binary.
Out of Scope Changes Check ✅ Passed All modifications are confined to bucket/greenshot-unstable.json and directly address the naming-change issue; there are no unrelated file edits or functionality changes in this PR. Therefore there are no apparent out-of-scope changes.
Description Check ✅ Passed The description explains the problem (UNSIGNED added to release filenames), states the corrective action (update URLs), includes "Closes #2461", and has the contributing-guide checkbox, satisfying the repository template's required fields and giving reviewers the necessary context. It is concise and sufficient for reviewers to understand intent and scope.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change: bumping greenshot-unstable to 1.3.299 and fixing checkver/autoupdate to match the new UNSIGNED naming, so it clearly communicates the PR's main intent to reviewers.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

greenshot-unstable

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bucket/greenshot-unstable.json (1)

20-20: Tighten regex to avoid accidental matches (anchor .exe).
Safer to match the installer asset explicitly; prevents matching a similarly named non-installer artifact in the future.

Apply:

-        "regex": "Greenshot-INSTALLER-([\\d.]+)-UNSTABLE-UNSIGNED"
+        "regex": "Greenshot-INSTALLER-([\\d.]+)-UNSTABLE-UNSIGNED\\.exe"
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe85ce5 and 11c6dbc.

📒 Files selected for processing (1)
  • bucket/greenshot-unstable.json (2 hunks)
🔇 Additional comments (3)
bucket/greenshot-unstable.json (3)

2-2: Version bump to 1.3.299 aligns with UNSIGNED asset naming — looks good.


23-23: Autoupdate URL updated to UNSIGNED variant — good.
This will follow the new naming going forward.


6-7: URL and hash verified — UNSIGNED installer asset is live and checksum matches.
Downloaded successfully (HTTP 200, 4,207,170 bytes); SHA256 = 2a03634d14f0de9ae319c06bc4800ee89011374018bb042f15a378e4e82d4951 (matches JSON).

@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Sep 21, 2025

Thanks! By the way, please make sure to follow the Contributing Guide next time.

Submit your pull request. Titles should follow these rules:
* If it's a new manifest, use <app name>: Add version <version>.
* If it's an update to an existing manifest, use <app name>@<version>: <small description>.
* If it's something related to maintenance, use (chore): <small description>.

@z-Fng
Copy link
Copy Markdown
Member

z-Fng commented Sep 21, 2025

/verify

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

greenshot-unstable

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng changed the title fix(greenshot-unstable): 🐛 Update the url to include new UNSIGNED naming greenshot-unstable: Update to version 1.3.299, fix checkver & autoupdate Sep 21, 2025
Copy link
Copy Markdown
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng merged commit deada88 into ScoopInstaller:master Sep 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Update greenshot-unstable manifest for new naming scheme

2 participants