Confirm showNotifications setting optimization in useStreamStats#49
Merged
southernmagilla merged 1 commit intofix/rtmp-crashesfrom Feb 1, 2026
Merged
Confirm showNotifications setting optimization in useStreamStats#49southernmagilla merged 1 commit intofix/rtmp-crashesfrom
southernmagilla merged 1 commit intofix/rtmp-crashesfrom
Conversation
Merged
Copilot
AI
changed the title
[WIP] Address feedback on RTMP crash fix implementation
Confirm showNotifications setting optimization in useStreamStats
Feb 1, 2026
southernmagilla
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comment requested verification that
showNotificationssetting is no longer read multiple times inhandleAutoRetry.Current Implementation
The setting is read once at function entry and reused throughout:
This eliminates the duplicate
getState()calls that were present in the original implementation.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.