Merged
Conversation
we are using yarn to install and build in the Dockerfile so it is best to make it consistent. removed package-lock.json as well.
as well as add context to github action docker image build job.
Closed
Member
Author
|
Going to test ci with pre-release |
Member
Author
|
CI is as usual (https://github.com/ScoreTrak/client/actions/runs/2104081944) and inspecting the container with dive (https://gochronicles.com/dive/) show the same output as previous containers. |
L1ghtman2k
approved these changes
Apr 6, 2022
Member
|
This is a lot of files to check haha, If it looked fine on ur end, let's merge this |
Member
Author
|
Yeah a lot of files, haha. Just moving them from one folder to another spams the files changed count :(. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented mono repo and added scoretrak-scoretrakapis repo contained buf generated output.