[Bug] tools/cli-wallet generates legacy Base58 RTC addresses

[eliasx45]

Summary

The legacy CLI wallet under tools/cli-wallet appears to generate RustChain addresses in an older/incompatible Base58 format, while current wallet code and docs say signed-transfer addresses must be RTC + 40 hex characters.

Evidence

• tools/cli-wallet/src/main.rs:105-109 hashes the secp256k1 public key and formats the address as RTC + base58(hash[0..20]).
• tools/cli-wallet/src/main.rs:148-155 validates addresses by Base58-decoding the part after RTC and only requiring length >= 25.
• Current native wallet code derives addresses as RTC + sha256(ed25519_public_key_bytes)[:40] in rustchain-wallet/src/keys.rs:75-80.
• docs/API_WALKTHROUGH.md:211 says signed transfers require 43-character addresses: RTC + 40 hex.

Why this is confusing

A newcomer following the CLI wallet README can generate an address that starts with RTC, but the suffix is Base58 and the length is not the documented 40-hex format. That address can then fail in newer validation paths such as bridge/faucet/signed-transfer checks that expect ^RTC[0-9a-fA-F]{40}$.

Expected behavior

All wallet generators and validators should agree on one public format. If the modern format is canonical, tools/cli-wallet should derive RTC + first 40 hex chars of SHA-256 over the public key and validate with the same 43-character hex rule.

Actual behavior

tools/cli-wallet still uses Base58 address derivation/validation and secp256k1 key material, while the newer wallet uses Ed25519 and 40-hex RTC addresses.

Suggested fix

Either deprecate/remove the older tools/cli-wallet README/tool from onboarding paths, or update it to match rustchain-wallet address derivation and validation.

[github-actions]

Welcome to RustChain! Thanks for opening your first issue.

New here? Check out these resources:

• CONTRIBUTING.md — how to earn RTC bounties
• Good First Issues — easy starter tasks (5-10 RTC)
• Bounty Board — all open bounties

Earn RTC tokens by contributing code, docs, or security fixes. Every merged PR gets paid!

1 RTC = $0.10 USD | pip install clawrtc to start mining

[eliasx45]

Opened a focused fix PR for this: #6519

Summary: the legacy CLI wallet now generates RTC + 40 hex addresses, validates exact 43-character hex RTC addresses, updates README examples, and removes the unused Base58 dependency.

[eliasx45]

Additional reproduction detail for bounty/triage:

1. Inspect tools/cli-wallet/src/main.rs on the pre-fix head.
2. Wallet::new() formats generated addresses as RTC + Base58-encoded first 20 bytes of the public-key hash.
3. validate_address() accepts any RTC suffix that Base58-decodes and is at least 25 characters long.
4. Compare that with the canonical docs/native wallet format: RTC + exactly 40 hex characters.

Environment/scope: found by static source review on Windows 11 / PowerShell in Scottcjn/Rustchain; this is a deterministic source-level mismatch, not OS-specific runtime behavior.

Fix PR: #6519