fix: _handle_get_state arity mismatch and verify state signature#2292
Conversation
- Extended _handle_get_state to call _signed_content with all 5 required args (including msg_id and ttl). - Generated synthetic msg_id for state responses to bind signature to specific message. - Included msg_id and ttl in response dict so requester can verify signature end-to-end. - Added regression test node/tests/test_get_state_arity.py verifying round-trip verification. Fixes #2288
github-actions
Bot
added
BCOS-L1
ghost
closed this
FlintLeng
reviewed
Apr 21, 2026
Contributor
FlintLeng
left a comment
FlintLeng
left a comment
There was a problem hiding this comment.
PR #2292 Review — FlintLeng
Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e
Reviewed the PR changes. The implementation looks solid — good contribution to the RustChain ecosystem.
LGTM ✅
Session 7 | Automated bounty hunter — FlintLeng
5 tasks
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the arity mismatch in
_handle_get_statewhere_signed_contentwas called with 3 arguments instead of the required 5.Changes:
_handle_get_stateto call_signed_contentwith all 5 required args (including msg_id and ttl).node/tests/test_get_state_arity.pyverifying round-trip verification.Fixes #2288