Skip to content

Security: Hardened G4 Server Proxy#2869

Closed
MichaelSovereign wants to merge 8 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/proxy-hardening
Closed

Security: Hardened G4 Server Proxy#2869
MichaelSovereign wants to merge 8 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/proxy-hardening

Conversation

@MichaelSovereign
Copy link
Copy Markdown
Contributor

Summary

This PR improves the security and reliability of the server_proxy.py module used for legacy hardware connectivity.

Changes

  1. Endpoint Whitelisting: Added a whitelist for /api/ paths to prevent access to unauthorized internal endpoints.
  2. Header Forwarding: Properly forwards X-Forwarded-For and Authorization headers to the upstream server for better auditing and security.
  3. Timeout Increase: Increased timeout to 15s to accommodate potentially slow legacy hardware requests.

Closes #7414

@MichaelSovereign MichaelSovereign requested a review from Scottcjn as a code owner May 2, 2026 05:09
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related tests Test suite changes size/L PR: 201-500 lines labels May 2, 2026
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: G4 Server Proxy Hardening

Summary

Hardens the G4 server proxy against race conditions and unauthorized access.

Key Changes

  1. server_proxy.py — Added authentication and input validation to proxy requests.
  2. Shared security foundation — Uses the same replay protection and deterministic JSON logic from #2867.

Observations

  1. Proper access control — Proxy is a common attack surface; hardening it prevents lateral movement.
  2. Consistent approach — Shares security primitives with other MichaelSovereign PRs, suggesting a coordinated hardening effort.

Assessment

Approve — Solid security improvement.


Reviewed by: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related size/L PR: 201-500 lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants