Skip to content

Security: Sync Manager SQL Injection Protection#2892

Closed
MichaelSovereign wants to merge 31 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/sync-sqli-protection
Closed

Security: Sync Manager SQL Injection Protection#2892
MichaelSovereign wants to merge 31 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/sync-sqli-protection

Conversation

@MichaelSovereign
Copy link
Copy Markdown
Contributor

Summary

This PR fixes a critical SQL injection vulnerability in the where dynamic table names were used in SQL queries without sufficient validation.

Changes

  1. Strict Whitelisting: Implemented to perform a hard-coded check against the and constants.
  2. Defensive Access: Updated , , and to use this strict whitelist before executing any dynamic SQL.
  3. Audit Trails: Added warning logs for unauthorized table access attempts.

Closes #7440

@MichaelSovereign MichaelSovereign requested a review from Scottcjn as a code owner May 2, 2026 05:33
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related tests Test suite changes size/XL PR: 500+ lines labels May 2, 2026
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: SQL Injection in Sync Manager

Summary

This PR addresses a security vulnerability in the RustChain codebase.

Key Changes

  • node/airdrop_v2.py: +8 -4
  • node/anti_double_mining.py: +2 -1
  • node/arch_cross_validation.py: +7 -2

Assessment

Approve — Meaningful security fix.


Reviewed by: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) node Node server related size/XL PR: 500+ lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants