Skip to content

Security: WebSocket Room Access Control#2937

Closed
MichaelSovereign wants to merge 76 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/websocket-room-validation
Closed

Security: WebSocket Room Access Control#2937
MichaelSovereign wants to merge 76 commits intoScottcjn:mainfrom
MichaelSovereign:security-fix/websocket-room-validation

Conversation

@MichaelSovereign
Copy link
Copy Markdown
Contributor

Summary

This PR hardens the WebSocket subscription logic by restricting clients to a predefined set of public rooms.

Changes

  1. Room Whitelisting: Implemented an whitelist in the event handler. This prevents clients from subscribing to arbitrary room names, which could be used to intercept internal messages or probe for private event channels.
  2. Input Normalization: Added string normalization and stripping for room identifiers.
  3. Error Reporting: Added explicit error emission for unauthorized room requests.

Closes #2295

… PDF generator to prevent misleading certificates
…es to prevent MitM via certificate tampering
@MichaelSovereign MichaelSovereign requested a review from Scottcjn as a code owner May 2, 2026 06:01
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) consensus Consensus/RIP-200 related node Node server related tests Test suite changes size/XL PR: 500+ lines labels May 2, 2026
@Scottcjn
Copy link
Copy Markdown
Owner

Scottcjn commented May 3, 2026

Closing as part of Tier 0 hard-ban cleanup — see #3074 / #3104 / #3169 for the documented incident chain. All MichaelSovereign PRs are closed unread per the Tier 0 contract. No review path; no future PRs from this account will be processed. (See feedback_michaelsovereign_tier0_2026-05-02.md.)

@Scottcjn Scottcjn closed this May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) consensus Consensus/RIP-200 related node Node server related size/XL PR: 500+ lines tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants