feat: RIP-309 Phase 1 - Rotating Measurement Freshness#3209
feat: RIP-309 Phase 1 - Rotating Measurement Freshness#3209slendereater-sketch wants to merge 1 commit intoScottcjn:mainfrom
Conversation
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
jaxint
left a comment
There was a problem hiding this comment.
PR Review: RIP-309 Phase 1 - Rotating Measurement Freshness
Summary
This PR significantly simplifies the RIP-309 implementation by reducing a 352-line module to 44 lines.
Key Changes
- Massive code reduction: 352 → 44 lines (87% reduction)
- Fingerprint check names changed:
- Removed:
cache_timing,simd_identity,thermal_drift,instruction_jitter,anti_emulation - Added:
instruction_latency,memory_throughput,cpu_identity,pci_fingerprint,disk_io_pattern
- Removed:
- Removed features: EMA scoring, spike detection, bimodal observation windows, SQLite persistence, logging, self-test
⚠️ Concerns
- Breaking change: Fingerprint check names changed completely - will break existing miners
- Feature regression: Core anti-Goodhart features removed
- No documentation: Design principles removed
- Missing validation: No edge case handling
Questions
- Are new check names implemented in
fingerprint_checks.py? - Is this a breaking change requiring migration guide?
- Phase 2 timeline?
Assessment
Reviewed by: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
|
Closing — wrong bounty reference. You cite The actual RIP-309 work has been ongoing in the codebase for weeks. RIP-309 Phase 1 (4-of-6 rotating measurement freshness) was already implemented and paid earlier in April. Your PR's net -345 line deletion suggests you're rewriting an existing implementation — that's risky without prior coordination. If you want to contribute substantively:
Closing without payment. — Scott |
Implementing the 4-of-6 rotating hardware attestation logic as specified in RIP-309. This module ensures deterministic but unpredictable rotation of fingerprint checks using the previous block hash as a seed. It also implements weighted pass-rate reward calculation to avoid strict gating. Closes bounty #3008.