security: add ownership verification to contract state transitions#3943
Merged
Scottcjn merged 2 commits intoScottcjn:mainfrom May 4, 2026
Merged
Conversation
- Updates python-socketio to latest stable version 5.16.1 - Includes bug fixes and performance improvements - Closes Scottcjn#2830
…cottcjn#3217) HIGH severity fix: prevent unauthorized contract state changes - Require X-Agent-Key header for authentication - Verify caller is from_agent or to_agent of the contract - Validate state transitions (offered->active->completed, no arbitrary jumps) - Only to_agent can accept contracts - Only from_agent can mark contracts as breached - Terminal states (completed/breached/expired) cannot be changed Fixes Scottcjn#3217
Owner
|
Paid: 15 RTC. pending_id Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3217 — HIGH severity: unauthorized contract state changes possible.
Changes
X-Agent-Keyheader for contract state updatesfrom_agentorto_agentof the contractto_agentcan accept contracts (offered → active)from_agentcan mark contracts as breachedFix Details
File:
node/beacon_api.pyBefore the fix, the
/api/contracts/<contract_id>PUT endpoint allowed anyone to change contract state to any value without authentication or validation.The fix adds:
Impact