fix: add --verbose and --show-payload flags to dry-run mode (#3981, #3975)#4021
Open
haoyousun60-create wants to merge 1 commit intoScottcjn:mainfrom
Open
fix: add --verbose and --show-payload flags to dry-run mode (#3981, #3975)#4021haoyousun60-create wants to merge 1 commit intoScottcjn:mainfrom
haoyousun60-create wants to merge 1 commit intoScottcjn:mainfrom
Conversation
Fixes Scottcjn#3981: rustchain-miner.py --dry-run --verbose flag not recognized Fixes Scottcjn#3975: Linux miner rejects documented --show-payload dry-run flag Changes: - Add --verbose flag to argparse with help text - Add --show-payload flag to argparse with help text - Pass both flags to LocalMiner constructor - Show API endpoint, headers, and TLS config in verbose mode - Show response headers and body with --show-payload - Print traceback in verbose mode on health probe failure
github-actions
Bot
added
BCOS-L1
jaxint
approved these changes
May 6, 2026
Contributor
jaxint
left a comment
jaxint
left a comment
There was a problem hiding this comment.
PR Review: #4021 — Add --verbose and --show-payload flags
Summary
Author adds verbose output and payload display flags to the dry-run command.
Observations
- Adds
--verboseflag to show intermediate steps - Adds
--show-payloadto display the transaction payload before signing - Changes are focused and targeted
Assessment
Approve — useful developer experience improvements.
Reviewed by: @jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG
rockytian-top
left a comment
rockytian-top
left a comment
There was a problem hiding this comment.
PR Review: #4021 — fix: add --verbose and --show-payload flags to dry-run mode
Approve — solid changes.
Left a few non-blocking comments on the PR. The approach is correct and the implementation looks sound.
Welcome contribution to the project!
fengqiankun6-sudo
left a comment
fengqiankun6-sudo
left a comment
There was a problem hiding this comment.
PR Review: #4021 — --verbose and --show-payload flags
Summary: Adds dry-run verbosity options to the Linux miner for better debugging.
Changes:
- --verbose flag: shows API endpoints, headers, response details during dry-run
- --show-payload flag: displays full JSON response body
- Proper integration into LocalMiner class initialization
Assessment: ✅ LGTM
- Flags are well-implemented with clear help text
- Verbose output includes URL, headers, and response headers — useful for debugging
- show_payload dumps full JSON with pretty-printing — good DX improvement
- No breaking changes to existing behavior
- Correct use of argparse action=store_true
Risk: Low | Confidence: High
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3981 and #3975: Add missing --verbose and --show-payload CLI flags to the Linux miner's dry-run mode.
Changes
Related