feat: Professional Windows Installer (.exe) for RustChain Miner (Bounty #53) #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrigajtis
reviewed
Feb 10, 2026
mgrigajtis
left a comment
mgrigajtis
left a comment
There was a problem hiding this comment.
This is an ambitious and valuable PR, but it’s very large and includes a few high-risk items for maintainability.
Key review points / requests:
- Repo bloat / binary & vendored files
- miners/windows/python-3.10.11-embed-amd64.zip is a binary blob. That will inflate repo size and complicate history.
- miners/windows/get-pip.py is ~27k lines (vendored). If possible, download these at build/install time instead of committing.
- Supply-chain integrity
- If you do download at install time, please add checksum validation for downloaded artifacts (embedded python zip, get-pip, etc.).
- Consider pinning versions + hashes in a single manifest.
- Privilege / persistence
- The PR mentions Scheduled Tasks / auto-start. Please document exactly what is created/modified and provide an uninstall path.
- Separation of concerns
- Suggest splitting into:
(A) Windows miner + docs
(B) Installer tooling (Inno/NSIS/PyInstaller scripts)
(C) Bundling embedded python (if kept)
- Security
- Any auto-update / download mechanism should be HTTPS + pinned hashes to reduce MITM risk.
If you can split the PR and avoid committing large binaries, it will be much easier to review and merge.
TheFrogEcliptia
pushed a commit
to TheFrogEcliptia/Rustchain
that referenced
this pull request
Feb 10, 2026
…argeting common node weaknesses
TheFrogEcliptia
pushed a commit
to TheFrogEcliptia/Rustchain
that referenced
this pull request
Feb 10, 2026
muhammetsimssek
force-pushed
the
bounty-53-windows-installer
branch
2 times, most recently
from
3c8e96c to
097612b
Compare
Author
🚀 Major Refactor & Cleanup — Bounty #53Based on the feedback regarding maintainability and repo bloat (@mgrigajtis), I have completely refactored this PR:
VerificationI've included a screenshot ('miners/windows/installer/assets/screenshot.png') showing the installer workflow and the miner running successfully on Windows 11. Ready for final review. @Scottcjn |
muhammetsimssek
force-pushed
the
bounty-53-windows-installer
branch
2 times, most recently
from
b3f771d to
bf43434
Compare
…tcjn#53) Includes: - Single .exe installer with bundled Python and dependencies - Wallet name prompting during setup - System tray icon with status indicator (Bonus) - Start Menu shortcuts and optional auto-start - Clean logs management in %APPDATA% - SSL verify=False support for self-signed node certs
muhammetsimssek
force-pushed
the
bounty-53-windows-installer
branch
from
bf43434 to
2d270dc
Compare
…ation and miner operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a standalone Windows installer using PyInstaller and Inno Setup.
Features
Payout Details
Closes #53