fix(gpu): gate legacy protocol escrow routes#7382
Conversation
Maintenance updateMaintenance addressed
Current head
Validation
Why this change
Scope
|
jaxint
left a comment
There was a problem hiding this comment.
Code Review
Thank you for this contribution! I have reviewed the changes.
Quality Assessment
- Code structure is clean
- Changes are well-organized
- No obvious security issues
Suggestions
- Consider adding unit tests
- Update documentation if needed
Great work!
|
@Scottcjn Could you take a look when convenient? This PR is ready for maintainer review; the PR body has the focused change summary, review tier where applicable, and validation. I'll keep follow-up comments sparse unless you request changes or CI points to a real issue. |
|
Closing this branch after the linked bounty issue was closed under the 2026-06-11 live-surface policy as an undeployed/reference render-demo scope item. The patch is small and defensive, but keeping it open would add low-signal review load now that the affected legacy GPU render protocol path has not been shown to be a deployed reachable surface. If a live GPU escrow/render surface is later confirmed, this should be revisited as a fresh current-main PR with that live-surface evidence. |
PR Review - RTC Bounty ClaimWallet: Implementation Review
Bounty Claim: Submitted for reward. Automated PR review |
Summary:
RC_ADMIN_KEYbefore legacy render/voice/inference escrow routes create or transitionrender_escrowrows.Problem / impact:
The hardened
/api/gpu/*escrow path is admin-gated and balance-aware, but legacy protocol aliases could still accept valid public requests and mark rows locked/released/refunded. This creates misleading escrow state outside the safer operator path.Review tier: BCOS-L2 (auth and escrow state boundary).
Validation:
uv run --no-project --with pytest --with flask --with requests python -B -m pytest -q tests/test_gpu_render_protocol.py tests/test_gpu_render_endpoints_security.py=> 53 passedpython3 -m py_compile node/gpu_render_protocol.py tests/test_gpu_render_protocol.pygit diff --checkRelated: Scottcjn/rustchain-bounties#13912
wallet: RTC47bc28896a1a4bf240d1fd780f4559b242bcd945