Fix case-sensitive effect name comparison#494
Merged
NateXS merged 1 commit intoScratchEverywhere:mainfrom Dec 12, 2025
Merged
Conversation
Member
|
It might be worth checking if this affects other blocks that use systems like this, I'm thinking maybe the pen blocks? |
gradylink
approved these changes
Dec 12, 2025
Effect names from project.json are lowercase but code compares uppercase. Add std::transform to normalize before comparison.
kalomaze
force-pushed
the
case-sensitive-clone-fix
branch
from
6394e68 to
5eb8aea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect names in project.json can be lowercase in some contexts (e.g., "ghost"), but the code compared against uppercase ("GHOST"). Added std::transform to normalize effect names to uppercase before comparison.