refactor: move webview/ into src/anthias_webview#2896
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
This PR relocates the Qt-based WebView source from the top-level webview/ directory to src/anthias_webview/, aligning it with the other src/anthias_* packages. It updates all path references in Dockerfiles, build scripts, config files (ruff/mypy excludes), comment pointers, and documentation.
Changes:
- Moves
webview/→src/anthias_webview/(no source code changes). - Updates Dockerfile COPY/WORKDIR paths and shell
WEBVIEW_DIRto point at the new location. - Updates references in
ruff.toml,pyproject.toml, comments in Python/C++ files, and Markdown docs (CLAUDE.md, README.md, CONTRIBUTING.md, developer docs).
Reviewed changes
Copilot reviewed 14 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/anthias_webview/** | Relocated webview package (Dockerfile, build_qt5.sh, README, .pro, sysroot script, src/, res/) with internal comment path fixes. |
| docker/Dockerfile.viewer.j2 | Updated COPY/WORKDIR for the Qt6 in-tree webview source. |
| docker/Dockerfile.qt5-webview-builder.j2 | Updated COPY paths and comments for the Qt5 cross-build pipeline. |
| bin/rebuild_qt5_toolchain.sh | WEBVIEW_DIR repointed at src/anthias_webview. |
| ruff.toml / pyproject.toml | Updated exclude paths for the vendored sysroot script. |
| src/anthias_server/app/models.py | Updated comment pointer to view.cpp. |
| src/anthias_viewer/init.py | Updated comment pointer to main.cpp. |
| tools/image_builder/utils.py | Updated comment pointer to build_qt5.sh. |
| CLAUDE.md / README.md / CONTRIBUTING.md / website/.../developer-documentation.md | Updated doc references and links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issues Fixed
N/A — repo layout cleanup.
Description
Move the Qt webview source from
webview/intosrc/anthias_webview/so it sits alongside the othersrc/anthias_*packages. All references updated:docker/Dockerfile.viewer.j2anddocker/Dockerfile.qt5-webview-builder.j2COPY/WORKDIR pathsbin/rebuild_qt5_toolchain.shWEBVIEW_DIR(in-container/webviewmount target left alone — arbitrary mount name)ruff.tomlandpyproject.tomlsysroot-relativelinks.pyexclusion pathsCLAUDE.md,README.md,CONTRIBUTING.md,website/content/docs/developer-documentation.md, the movedREADME.md,Dockerfile,build_qt5.shheaderssrc/anthias_server/app/models.py,src/anthias_viewer/__init__.py,tools/image_builder/utils.pyVerified:
uv run python -m tools.image_builder --dockerfiles-only --service viewerrenders cleanly for both a Qt6 board (default x86) and a Qt5 board (pi3);uv run ruff check .passes.Checklist
🤖 Generated with Claude Code