Skip to content

Edits: for initialized files on edge-app create #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rusko124 merged 3 commits into from
Aug 9, 2023
Merged

Edits: for initialized files on edge-app create #60

rusko124 merged 3 commits into from
Aug 9, 2023

Conversation

@rusko124
Copy link
Contributor

@rusko124 rusko124 commented Aug 8, 2023 •
edited
Loading

Ticket: https://ph.wireload.net/T7251

Edits:

  • Updated index.html using updated screenly.js (settings and metadata)
  • Added a default setting(username) to manifest that is used by the index.html
  • Added validation that manifest and index.html do not exist on edge-app create

Screenshot of testing on the viewer:
Screenshot from 2023-08-08 18-02-03

@rusko124 rusko124 changed the title Edits: initialized files on edge-app create Edits: for initialized files on edge-app create Aug 8, 2023
nicomiguelino
nicomiguelino reviewed Aug 8, 2023
View reviewed changes
@rusko124 rusko124 merged commit 686be9f into master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicomiguelino nicomiguelino nicomiguelino left review comments

@sergey-borovkov sergey-borovkov sergey-borovkov approved these changes

@renatgalimov renatgalimov renatgalimov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rusko124 @sergey-borovkov @nicomiguelino @renatgalimov