Fix misleading fibit step count#122
Merged
Jozys merged 2 commits intodevelopmentfrom Apr 13, 2025
Merged
Conversation
- sourceId is an empty string in most cases, so the sourceName, which is the packageId of the reporting app
ScreepCode
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Brief Description
This pull request fixes problems with the step calculation coming from Fitbit
Linked Issues
GitHub Copilot Text
This pull request includes an important change to the
BaseLocalHealthRepoImplclass in thelib/data/repositories/base_local_health_impl.dartfile. The change improves the logic for checking overlapping data points by ensuring that points from the same source are not considered overlapping.Key change:
sourceNameproperty of the points.