Fix pause/resume state handling in tracking view model#124
Merged
Jozys merged 1 commit intodevelopmentfrom Apr 13, 2025
Merged
Conversation
- Update activity tracking to include bug fixes
ScreepCode
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Brief Description
This pull request resolves an issue with the tracking timer to be start twice. This was caused by a bug in the activity_tracking library and a wrong state update.
Linked Issues
GitHub Copilot Text
This pull request includes a small but important change to the
TrackingViewModelclass in thelib/presentation/tracking/view_model/tracking_view_model.dartfile. The change corrects the logic for handlingpauseandresumeevents by swapping the values ofnewIsPaused.lib/presentation/tracking/view_model/tracking_view_model.dart: Corrected thenewIsPausedvalue forpauseandresumeevents to ensure the state is properly updated.