Request location service enablement in tracking#126
Merged
Jozys merged 1 commit intodevelopmentfrom Apr 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (3)
- lib/l10n/app_de.arb: Language not supported
- lib/l10n/app_en.arb: Language not supported
- lib/presentation/tracking/widgets/start_activity.dart: Language not supported
ScreepCode
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Brief Description
This pull request adds a check if location services are enabled if a user tries to start an activity tracking. If I fails the user is prompted to
Linked Issues
Screenshots
GitHub Copilot Text
This pull request includes several changes to improve the handling of location services and refine the localization files. The most important changes include updating the localization files for German and English, modifying the
StartActivitywidget to check for location services, and adding thegeolocatordependency.Localization Updates:
lib/l10n/app_de.arb: Removed unused tracking leave messages and added new messages for location services permissions.lib/l10n/app_en.arb: Removed unused tracking leave messages and added new messages for location services permissions.Codebase Enhancements:
lib/presentation/tracking/widgets/start_activity.dart: Updated theStartActivitywidget to check for location services before starting an activity and prompt the user to enable them if they are disabled.Dependency Management:
pubspec.yaml: Added thegeolocatordependency to handle location services.