Fix/systembars paddings and colors#127
Merged
ScreepCode merged 3 commits intodevelopmentfrom Apr 13, 2025
Merged
Conversation
…tion insets and support system windows for Android 11+
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (3)
- lib/main.dart: Language not supported
- lib/presentation/challenges/streak/screen/streak_details_screen.dart: Language not supported
- lib/presentation/common/navigator.dart: Language not supported
Jozys
approved these changes
Apr 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Brief Description
This pull request resolves an issue with missing margin bottom causing the system navigation to exclude content of the application. This is resolved by adding window insets to all screens without navigation bar
Linked Issues
Screenshots
GitHub Copilot Text
This pull request includes changes to the Android and Flutter codebases to improve UI behavior and code organization. The most important changes include modifications to the
MainActivityclass to handle system window insets, refactoring of theStreakDetailsScreento use a consistent header color, and updates to theMoveTopiaNavigatorto properly handle system insets and navigation bar behavior.Android Changes:
android/app/src/main/kotlin/de/buseslaar/movetopia/MainActivity.kt: UpdatedMainActivityto overrideonCreateand set the window to not fit system windows for Android R and above.Flutter Changes:
lib/presentation/challenges/streak/screen/streak_details_screen.dart: RefactoredStreakDetailsScreento use aheaderColorvariable for the header and app bar background color, ensuring consistency across the UI. [1] [2] [3] [4]lib/presentation/common/navigator.dart: UpdatedMoveTopiaNavigatorto handle system insets properly and ensure the bottom navigation bar extends behind the system navigation, improving the layout for screens with bottom navigation. [1] [2]