Skip to content

Fix badge item colors#132

Merged
ScreepCode merged 1 commit intodevelopmentfrom
fix/badge-texts
Apr 15, 2025
Merged

Fix badge item colors#132
ScreepCode merged 1 commit intodevelopmentfrom
fix/badge-texts

Conversation

@ScreepCode
Copy link
Copy Markdown
Owner

@ScreepCode ScreepCode commented Apr 15, 2025

🚀 Pull Request

Brief Description

Linked Issues

Screenshots

Screen 1
image

GitHub Copilot Text

This pull request includes changes to the lib/presentation/challenges/widgets/badge_item.dart file to improve the consistency and theming of the badge display components. The most important changes involve replacing hardcoded colors with colors from the ColorScheme provided by the app's theme.

Improvements to theming:

  • BadgeIcon class: Replaced hardcoded colors with colorScheme.outline and colorScheme.onSurfaceVariant for better theme consistency.
  • BadgeDetailsSection class: Updated text colors to use colorScheme.onSurface and colorScheme.onSurfaceVariant instead of hardcoded colors.
  • BadgeProgressSection class: Used colorScheme.surfaceContainerHighest and colorScheme.onSurfaceVariant for the progress bar and text colors. [1] [2]
  • BadgeAchievementDate class: Changed icon and text colors to use colorScheme.primary and colorScheme.onSurfaceVariant for achieved badges. [1] [2]

@ScreepCode ScreepCode added bug Something isn't working lib Label for flutter lib issues design Label for design specific issues labels Apr 15, 2025
@ScreepCode ScreepCode requested a review from Jozys April 15, 2025 16:18
@ScreepCode ScreepCode self-assigned this Apr 15, 2025
Copilot AI review requested due to automatic review settings April 15, 2025 16:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • lib/presentation/challenges/widgets/badge_item.dart: Language not supported

@ScreepCode ScreepCode merged commit 5409386 into development Apr 15, 2025
2 checks passed
@Jozys Jozys deleted the fix/badge-texts branch April 15, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working design Label for design specific issues lib Label for flutter lib issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants