Conversation
ScreepCode
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the activity tracking functionality, including the addition of pause/resume capabilities, updates to the tracking state, and improvements to the user interface.
Enhancements to Activity Tracking Functionality:
ActivityBroadcastReceiverinAndroidManifest.xmlto handle pause and stop actions for activity tracking.isPausedanddurationMillisfields inTrackingStateand modified thecopyWithmethod accordingly. [1] [2]togglePauseTrackingmethod inTrackingViewModelto handle pausing and resuming of activities, replacing the previouspauseTrackingmethod.startTimerandupdateDurationmethods inTrackingViewModelto work withdurationMillisinstead of a string duration.User Interface Improvements:
ActiveTrackingwidget to displaydurationMillisand handle paused state, including changes to the pause button icon. [1] [2]TrackingRecordingwidget to show the elapsed time and current speed, considering the paused state. [1] [2] [3] [4]TrackingFinishedwidget to display the total duration in milliseconds. [1] [2] [3]Code Refactoring:
durationMillisand to includeisPausedstate where necessary. [1] [2] [3] [4]TrackingViewModelby using constants from theEventclass.