Skip to content

GetTokens updated (password never leaves machine) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EHadoux merged 2 commits into from
Jun 20, 2023
Merged

GetTokens updated (password never leaves machine) #9

EHadoux merged 2 commits into from
Jun 20, 2023

Conversation

@ailinvenerus
Copy link
Contributor

@ailinvenerus ailinvenerus commented Jun 19, 2023

DONE

  • When using getTokens the password never leaves the machine
  • Auth class structure updated:
    • fedClient created only when identityPoolId is passed
    • clientId and userPoolId are mandatory
  • Tests updated

@ailinvenerus ailinvenerus added the enhancement New feature or request label Jun 19, 2023
@ailinvenerus ailinvenerus requested a review from EHadoux June 19, 2023 15:32
@ailinvenerus ailinvenerus self-assigned this Jun 19, 2023
@EHadoux EHadoux changed the title GetTokens updated (password never abandons machine) GetTokens updated (password never leaves machine) Jun 20, 2023
EHadoux
EHadoux requested changes Jun 20, 2023
View reviewed changes
@ailinvenerus ailinvenerus requested a review from EHadoux June 20, 2023 09:31
@EHadoux EHadoux merged commit 732dfae into master Jun 20, 2023
@EHadoux EHadoux deleted the feat/improve_get_tokens branch June 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EHadoux EHadoux EHadoux approved these changes

Assignees

@ailinvenerus ailinvenerus

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ailinvenerus @EHadoux