Skip to content

Remove image checks#2

Merged
OlegGulevskyy merged 2 commits intomasterfrom
remove-image-checks
May 30, 2022
Merged

Remove image checks#2
OlegGulevskyy merged 2 commits intomasterfrom
remove-image-checks

Conversation

@OlegGulevskyy
Copy link
Copy Markdown
Collaborator

It appears that when the images are too big the lib fails with the message
Wrong object. Please confirm it again. By the way, the maximum image size is 'width x height < 1048576'. And the mimeTypes are PNG, JPG and GIF.
This is due to the image size. I tested it with 4k image inserted in cell and it worked for me, so I am not sure why exactly there is a check apart from reference from README.md where it's stated:

When the images are retrieved from XLSX data, it seems that the image is a bit different from the original one. The image format is the same. But the data size is smaller than that of the original. When the image size is more than 2048 pixels and 72 dpi, the image is modified to 2048 pixels and 72 dpi. Even when the image size is less than 2048 pixels and 72 dpi, the file size becomes smaller than that of original one. So I think that the image might be compressed. Please be careful this.

I don't see a harm in using images more than the sizes in the checks apart from degraded image quality.
I suggest we come back to this if we have any complains about image quality degradation.

@OlegGulevskyy OlegGulevskyy requested a review from kengenouel May 23, 2022 15:05
@OlegGulevskyy OlegGulevskyy self-assigned this May 23, 2022
@OlegGulevskyy OlegGulevskyy merged commit 90c22ae into master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants