This repository was archived by the owner on Jan 22, 2024. It is now read-only.
Store configuration per-app #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al2o3cr
commented
Jun 29, 2020
| end | ||
|
|
||
| defp config_samly(conn, opts) do | ||
| opts = Keyword.put_new(opts, :otp_app, :samly) |
Author
There was a problem hiding this comment.
This default will ensure that unmodified apps continue working as before
al2o3cr
commented
Jun 29, 2020
| idp_id_from = Application.get_env(:samly, :idp_id_from) | ||
| otp_app = conn.private[:samly_config][:otp_app] | ||
|
|
||
| idp_id_from = Application.get_env(otp_app, Samly.Config).idp_id_from |
Author
There was a problem hiding this comment.
TODO: is it better to do these get_envs all over, or set the whole config in conn.private?
al2o3cr
commented
Jun 29, 2020
| Application.get_env(otp_app, Samly.Config, %{}) | ||
| |> Map.put(:state_store, value) | ||
|
|
||
| Application.put_env(otp_app, Samly.Config, new_config) |
Author
There was a problem hiding this comment.
TODO: if this is a pattern worth keeping, consider encapsulating it in a module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all Samly config to live under a particular OTP app, for use in umbrellas with multiple web frontends.
To wire this up, pass
otp_app: SomeOtpAppwhen startingSamly.Providerand to theSamly.Routerplug.TODO: is there a use case for multiple SPs in one Phoenix app, or should this be a singleton config? Could tidy up some things (no
sp_idetc)